Skip to content

JSF: skip looking for managed/named beans on incompatible JSF versions - #9489

Merged
matthiasblaesing merged 1 commit into
apache:masterfrom
NicolaIsotta:skip-managed-beans
Aug 30, 2026
Merged

JSF: skip looking for managed/named beans on incompatible JSF versions#9489
matthiasblaesing merged 1 commit into
apache:masterfrom
NicolaIsotta:skip-managed-beans

Conversation

@NicolaIsotta

@NicolaIsotta NicolaIsotta commented Jul 7, 2026 •
edited by matthiasblaesing
Loading

Copy link
Copy Markdown
Contributor
  • do not search CDI Named beans on JSF 2.1- (CDI support was introduced in 2.2)
  • do not search managed beans on Faces 4.0 or upper since support was removed

small code refactors/modernization

@mbien mbien added Java EE/Jakarta EE [ci] enable enterprise job enterprise [ci] enable enterprise job ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Jul 7, 2026
@apache apache locked and limited conversation to collaborators Jul 7, 2026
@apache apache unlocked this conversation Jul 7, 2026
@NicolaIsotta

NicolaIsotta commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Just a note: the current behavior doesn't actually cause errors or exceptions - the main purpose of the PR is performance

@mbien mbien added this to the NB31 milestone Jul 13, 2026
@mbien

mbien commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@NicolaIsotta this looks like a small change and I suppose you tested it. If you want we could try merging this for NB 31 if you rebase it soon (till Wednesday)

matthiasblaesing
matthiasblaesing reviewed Jul 13, 2026
View reviewed changes

@matthiasblaesing matthiasblaesing left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NicolaIsotta I'm wondering about the statements, that check for the JSF version. The current implementation is mixed in regard to beans to be not shown if the version can't be determined:

  • JsfELVariableResolver return beans based on ui:param if version can't be determined
  • WebBeansELVariableResolver does not return beans if version can't be determined
  • JSFBeanCache does not return beans if version can't be determined.

Would it make sense to unify this?!

@NicolaIsotta

NicolaIsotta commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Makes sense, I'll align the behaviors

BTW: this is just a small performance improvement, I think it can safely wait NB32

@mbien mbien modified the milestones: NB31, NB32 Jul 14, 2026
@neilcsmith-net neilcsmith-net modified the milestone: NB32 Jul 22, 2026
@NicolaIsotta

NicolaIsotta commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Updated and rebased, ready to merge

matthiasblaesing
matthiasblaesing reviewed Jul 30, 2026
View reviewed changes
Comment thread enterprise/web.jsf/src/org/netbeans/modules/web/jsf/api/editor/JSFBeanCache.java Outdated
@NicolaIsotta @matthiasblaesing
JSF: skip looking for managed/named beans on incompatible JSF versions
ca022b4 
- do not search CDI Named beans on JSF 2.1- (CDI support was introduced in 2.2)
- do not search managed beans on Faces 4.0 or upper, since support was removed

small code refactors/modernization

Co-authored-by: Matthias Bläsing <mblaesing@doppel-helix.eu>
@NicolaIsotta

NicolaIsotta commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Suggestion applied. Re-tested with 2.3 and 4.0 jsf projects, bean resolution looks on both.

@matthiasblaesing
matthiasblaesing merged commit 0d4d446 into apache:master Aug 30, 2026
57 of 58 checks passed
@matthiasblaesing

matthiasblaesing commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Thank you

@NicolaIsotta
NicolaIsotta deleted the skip-managed-beans branch August 30, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthiasblaesing matthiasblaesing matthiasblaesing left review comments

Assignees

No one assigned

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) enterprise [ci] enable enterprise job Java EE/Jakarta EE [ci] enable enterprise job performance

Projects

None yet

Milestone

NB32

Development

Successfully merging this pull request may close these issues.

4 participants

@NicolaIsotta @mbien @matthiasblaesing @neilcsmith-net